From 942fc042584c4657ea4f63389f4a1bc3fd3b6368 Mon Sep 17 00:00:00 2001 From: Doug Smythies Date: Sun, 15 Jun 2014 08:30:39 -0700 Subject: [PATCH 3/4] intel_pstate: fix mistake in target pstate change rounding. --- drivers/cpufreq/intel_pstate.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 5f38783..7e9d2ad 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -203,10 +203,7 @@ static signed int pid_calc(struct _pid *pid, int32_t busy) pid->last_err = fp_error; result = pterm + mul_fp(pid->integral, pid->i_gain) + dterm; - if (result >= 0) - result = result + (1 << (FRAC_BITS-1)); - else - result = result - (1 << (FRAC_BITS-1)); + result = result + (1 << (FRAC_BITS-1)); return (signed int)fp_toint(result); } -- 1.9.1